[ https://issues.apache.org/jira/browse/DRILL-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004531#comment-15004531 ]
ASF GitHub Bot commented on DRILL-4047: --------------------------------------- Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/246#discussion_r44821281 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java --- @@ -148,12 +175,427 @@ private Path getViewPath(String name) { return DotDrillType.VIEW.getPath(config.getLocation(), name); } - public WorkspaceSchema createSchema(List<String> parentSchemaPath, SchemaConfig schemaConfig) throws IOException { + public WorkspaceSchema createSchema(List<String> parentSchemaPath, SchemaConfig schemaConfig) throws IOException { return new WorkspaceSchema(parentSchemaPath, schemaName, schemaConfig); } - public class WorkspaceSchema extends AbstractSchema implements ExpandingConcurrentMap.MapValueFactory<String, DrillTable> { - private final ExpandingConcurrentMap<String, DrillTable> tables = new ExpandingConcurrentMap<>(this); + /** + * Describes the options for a format plugin + * extracted from the FormatPluginConfig subclass + */ + static final class OptionsDescriptor { --- End diff -- Can you pull this out into a separate file? > Select with options > ------------------- > > Key: DRILL-4047 > URL: https://issues.apache.org/jira/browse/DRILL-4047 > Project: Apache Drill > Issue Type: Improvement > Components: Execution - Relational Operators > Reporter: Julien Le Dem > Assignee: Julien Le Dem > > Add a mechanism to pass parameters down to the StoragePlugin when writing a > Select statement. > Some discussion here: > http://mail-archives.apache.org/mod_mbox/drill-dev/201510.mbox/%3CCAO%2Bvc4AcGK3%2B3QYvQV1-xPPdpG3Tc%2BfG%3D0xDGEUPrhd6ktHv5Q%40mail.gmail.com%3E > http://mail-archives.apache.org/mod_mbox/drill-dev/201511.mbox/%3ccao+vc4clzylvjevisfjqtcyxb-zsmfy4bqrm-jhbidwzgqf...@mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)