[
https://issues.apache.org/jira/browse/DRILL-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097266#comment-15097266
]
ASF GitHub Bot commented on DRILL-4270:
---------------------------------------
Github user adeneche commented on the pull request:
https://github.com/apache/drill/pull/322#issuecomment-171470081
The purpose of this PR is to separate the functions that support the FRAME
clause in CustomFrameTemplate from the ones that don't in DefaultFrameTemplate.
Work still needs to be done to make the refactoring complete (like making sure
code is not duplicated between the templates), but I decided to leave it after
I make the necessary changes to support the FRAME clause.
@amansinha100 can you please review ?
> Create a separate WindowFramer that supports the FRAME clause
> -------------------------------------------------------------
>
> Key: DRILL-4270
> URL: https://issues.apache.org/jira/browse/DRILL-4270
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Execution - Relational Operators
> Affects Versions: 1.5.0
> Reporter: Deneche A. Hakim
> Assignee: Aman Sinha
> Fix For: Future
>
>
> Currently most the window functions logic is handled by DefaultFrameTemplate.
> Create a separate CustomFrameTemplate that handles the FRAME clause, this
> should make the code in both classes more focused and will make it easier for
> us to add support for the FRAME clause.
> Aggregations, FIRST_VALUE and LAST_VALUE will be handled by
> CustomFrameTemplate, and all remaining window functions (Ranking, ROW_NUMBER,
> LEAD and LAG) will be handled by DefaultFrameTemplate.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
