[
https://issues.apache.org/jira/browse/DRILL-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102208#comment-15102208
]
ASF GitHub Bot commented on DRILL-4270:
---------------------------------------
Github user amansinha100 commented on the pull request:
https://github.com/apache/drill/pull/322#issuecomment-172038682
Overall refactoring looks ok. One thing that needs some clarity: Is the
definition of default frame 'between unbounded preceding and current row' ? If
the user explicitly specifies this frame in the query, will it be treated as
default or custom frame (as opposed to not specifying anything frame) ?
> Create a separate WindowFramer that supports the FRAME clause
> -------------------------------------------------------------
>
> Key: DRILL-4270
> URL: https://issues.apache.org/jira/browse/DRILL-4270
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Execution - Relational Operators
> Affects Versions: 1.5.0
> Reporter: Deneche A. Hakim
> Assignee: Aman Sinha
> Fix For: Future
>
>
> Currently most the window functions logic is handled by DefaultFrameTemplate.
> Create a separate CustomFrameTemplate that handles the FRAME clause, this
> should make the code in both classes more focused and will make it easier for
> us to add support for the FRAME clause.
> Aggregations, FIRST_VALUE and LAST_VALUE will be handled by
> CustomFrameTemplate, and all remaining window functions (Ranking, ROW_NUMBER,
> LEAD and LAG) will be handled by DefaultFrameTemplate.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
