[ 
https://issues.apache.org/jira/browse/DRILL-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406258#comment-15406258
 ] 

ASF GitHub Bot commented on DRILL-4792:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/551#discussion_r73379414
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java
 ---
    @@ -338,7 +345,8 @@ private QueryProfile getQueryProfile(UserException ex) {
             .setStart(startTime)
             .setEnd(endTime)
             .setTotalFragments(fragmentDataSet.size())
    -        .setFinishedFragments(finishedFragments.get());
    +        .setFinishedFragments(finishedFragments.get())
    +        .addAllOptions(queryOptions);
    --- End diff --
    
    We 
[serialize](https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/SimpleParallelizer.java#L292)
 and 
[deserialize](https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java#L149)
 options elsewhere. We should do something similar here as well.


> Include session options used for a query as part of the profile
> ---------------------------------------------------------------
>
>                 Key: DRILL-4792
>                 URL: https://issues.apache.org/jira/browse/DRILL-4792
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.7.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>            Priority: Minor
>             Fix For: 1.8.0
>
>         Attachments: no_session_options.JPG, session_options_block.JPG, 
> session_options_collapsed.JPG, session_options_json.JPG
>
>
> Include session options used for a query as part of the profile.
> This will be very useful for debugging/diagnostics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to