[
https://issues.apache.org/jira/browse/DRILL-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410613#comment-15410613
]
ASF GitHub Bot commented on DRILL-4792:
---------------------------------------
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/551#discussion_r73786030
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java
---
@@ -338,7 +345,8 @@ private QueryProfile getQueryProfile(UserException ex) {
.setStart(startTime)
.setEnd(endTime)
.setTotalFragments(fragmentDataSet.size())
- .setFinishedFragments(finishedFragments.get());
+ .setFinishedFragments(finishedFragments.get())
+ .addAllOptions(queryOptions);
--- End diff --
I have updated code to serialize and deserialize options as you suggested.
Now they are added as json string (optionsJson, as in examples you mentioned).
Though profile json representation contains escapes for such string, which is
probably is not as nice as was before. But it's the only way to display json
string inside of json.
If you want, I can revert the changes back to using prototype buffer option
object.
> Include session options used for a query as part of the profile
> ---------------------------------------------------------------
>
> Key: DRILL-4792
> URL: https://issues.apache.org/jira/browse/DRILL-4792
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.7.0
> Reporter: Arina Ielchiieva
> Assignee: Arina Ielchiieva
> Priority: Minor
> Fix For: 1.8.0
>
> Attachments: no_session_options.JPG, session_options_block.JPG,
> session_options_collapsed.JPG, session_options_json.JPG
>
>
> Include session options used for a query as part of the profile.
> This will be very useful for debugging/diagnostics.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
