[ https://issues.apache.org/jira/browse/DRILL-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636774#comment-15636774 ]
ASF GitHub Bot commented on DRILL-4604: --------------------------------------- Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/482#discussion_r86568133 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRoot.java --- @@ -55,44 +59,89 @@ public Viewable getStats() { @GET @Path("/stats.json") @Produces(MediaType.APPLICATION_JSON) - public List<Stat> getStatsJSON() { - List<Stat> stats = Lists.newLinkedList(); - stats.add(new Stat("Number of Drill Bits", work.getContext().getBits().size())); - int number = 0; - for (CoordinationProtos.DrillbitEndpoint bit : work.getContext().getBits()) { - String initialized = bit.isInitialized() ? " initialized" : " not initialized"; - stats.add(new Stat("Bit #" + number, bit.getAddress() + initialized)); - ++number; + public Stats getStatsJSON() { --- End diff -- This message gets statistics, which is great. But, it seems to combine per-cluster stats with per-drillbit info. Perhaps either have two messages (one for cluster, the other for Drillbit) or use JSON structures: ``` clusterStats: { drillbitCount: .., version: ... }, drillbitStats: { userPort: ..., ... } ``` > Generate warning on Web UI if drillbits version mismatch is detected > -------------------------------------------------------------------- > > Key: DRILL-4604 > URL: https://issues.apache.org/jira/browse/DRILL-4604 > Project: Apache Drill > Issue Type: Improvement > Affects Versions: 1.6.0 > Reporter: Arina Ielchiieva > Assignee: Sudheesh Katkam > Labels: doc-impacting > Fix For: Future > > Attachments: index_page.JPG, index_page_mismatch.JPG, > screenshots_with_different_states.docx > > > Display drillbit version on web UI. If any of drillbits version doesn't match > with current drillbit, generate warning. > Screenshots - screenshots_with_different_states.docx. -- This message was sent by Atlassian JIRA (v6.3.4#6332)