[
https://issues.apache.org/jira/browse/DRILL-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636806#comment-15636806
]
ASF GitHub Bot commented on DRILL-4604:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/482#discussion_r86575055
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java ---
@@ -218,13 +218,18 @@ private void javaPropertiesToSystemOptions() {
}
/**
- * If cluster version is the same as default, update option to current
drillbit version.
+ * If cluster version is the same as default, updates option to current
drillbit version.
+ * Since getOption and setOption are separate calls, raise condition
might occur
+ * when several drillbits are registering at the same time.
+ * It is assumed that the first drillbit in cluster sets cluster version
+ * but when the raise condition occurs, it might be the second or the
third etc.
+ * This behaviour does not impose significant impact, since the main
goal is to detect mismatching versions.
*/
- private void checkAndUpdateClusterVersionOption(OptionManager
optionManager, DrillbitEndpoint drillbitEndpoint) {
- OptionValue versionOption =
optionManager.getOption(ExecConstants.CLUSTER_VERSION);
+ private void checkAndUpdateClusterVersionOption(OptionManager
systemOptions, DrillbitEndpoint drillbitEndpoint) {
--- End diff --
How can this work? Consider this:
1. Start a new cluster.
2. A Drillbit registers. It sets the cluster version.
3. A second Drillbit registers. Does it reset the version? Or, does it
accept that the first has already set the version?
4. Shut down the cluster.
5. Upgrade Drill to a new version.
6. Start the first Drillbit.
7. Does this Drillbit overwrite the cluster version? Or, accept the
existing (old) version?
Note that steps 3 and 7 are identical from ZK's perspective.
> Generate warning on Web UI if drillbits version mismatch is detected
> --------------------------------------------------------------------
>
> Key: DRILL-4604
> URL: https://issues.apache.org/jira/browse/DRILL-4604
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.6.0
> Reporter: Arina Ielchiieva
> Assignee: Sudheesh Katkam
> Labels: doc-impacting
> Fix For: Future
>
> Attachments: index_page.JPG, index_page_mismatch.JPG,
> screenshots_with_different_states.docx
>
>
> Display drillbit version on web UI. If any of drillbits version doesn't match
> with current drillbit, generate warning.
> Screenshots - screenshots_with_different_states.docx.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
