[
https://issues.apache.org/jira/browse/DRILL-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15803145#comment-15803145
]
ASF GitHub Bot commented on DRILL-4280:
---------------------------------------
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r94701486
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -246,28 +163,78 @@ protected void handle(UserClientConnectionImpl
connection, int rpcType, ByteBuf
public class UserClientConnectionImpl extends RemoteConnection
implements UserClientConnection {
private UserSession session;
+ private SaslServer saslServer;
+ private RequestHandler<UserClientConnectionImpl> currentHandler;
+ private UserToBitHandshake inbound;
public UserClientConnectionImpl(SocketChannel channel) {
super(channel, "user client");
+ currentHandler = authFactory == null ? handler : new
UserServerAuthenticationHandler(handler, loginManager);
}
void disableReadTimeout() {
getChannel().pipeline().remove(BasicServer.TIMEOUT_HANDLER);
}
- void setUser(final UserToBitHandshake inbound) throws IOException {
+ void setHandshake(final UserToBitHandshake inbound) {
+ this.inbound = inbound;
+ }
+
+ void initSaslServer(final String mechanismName, final Map<String, ?>
properties)
+ throws IllegalStateException, IllegalArgumentException,
SaslException {
+ if (saslServer != null) {
+ throw new IllegalStateException("SASL server already
initialized.");
+ }
+
+ this.saslServer = authFactory.getMechanism(mechanismName)
+ .createSaslServer(properties);
+ if (saslServer == null) {
+ throw new SaslException("Server could not initiate authentication.
Insufficient parameters?");
--- End diff --
Shouldn't the exception message here be "Failed to initialize Sasl Server",
since that's what the function is doing ?
> Kerberos Authentication
> -----------------------
>
> Key: DRILL-4280
> URL: https://issues.apache.org/jira/browse/DRILL-4280
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Keys Botzum
> Assignee: Sudheesh Katkam
> Labels: security
>
> Drill should support Kerberos based authentication from clients. This means
> that both the ODBC and JDBC drivers as well as the web/REST interfaces should
> support inbound Kerberos. For Web this would most likely be SPNEGO while for
> ODBC and JDBC this will be more generic Kerberos.
> Since Hive and much of Hadoop supports Kerberos there is a potential for a
> lot of reuse of ideas if not implementation.
> Note that this is related to but not the same as
> https://issues.apache.org/jira/browse/DRILL-3584
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
