[ 
https://issues.apache.org/jira/browse/DRILL-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15803155#comment-15803155
 ] 

ASF GitHub Bot commented on DRILL-4280:
---------------------------------------

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/578#discussion_r94862522
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/rpc/security/TestSaslExchange.java
 ---
    @@ -0,0 +1,63 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.rpc.security;
    +
    +import com.google.common.collect.Lists;
    +import com.typesafe.config.ConfigValueFactory;
    +import org.apache.drill.BaseTestQuery;
    +import org.apache.drill.common.config.ConnectionParameters;
    +import org.apache.drill.common.config.DrillConfig;
    +import org.apache.drill.exec.ExecConstants;
    +import org.junit.AfterClass;
    +import org.junit.BeforeClass;
    +import org.junit.Test;
    +
    +import java.security.Security;
    +import java.util.Properties;
    +
    +public class TestSaslExchange extends BaseTestQuery {
    +
    +  @BeforeClass
    +  public static void setup() {
    +    Security.addProvider(new SimpleProvider());
    +    FastSaslServerFactory.reload();
    +
    +    final Properties props = cloneDefaultTestConfigProperties();
    +    final DrillConfig newConfig = new DrillConfig(DrillConfig.create(props)
    +        .withValue(ExecConstants.USER_AUTHENTICATION_ENABLED,
    +            ConfigValueFactory.fromAnyRef("true"))
    +        .withValue(ExecConstants.AUTHENTICATION_MECHANISMS,
    +            
ConfigValueFactory.fromIterable(Lists.newArrayList(SimpleMechanism.MECHANISM_NAME))),
    +        false);
    +
    +    final Properties connectionProps = new Properties();
    +    connectionProps.setProperty(ConnectionParameters.PASSWORD, "anything 
works!");
    +    updateTestCluster(3, newConfig, connectionProps);
    --- End diff --
    
    How does client knows to instantiate "SimpleMechanism" in this case? I 
don't see getClientAuthenticationHandler generating authHandler for 
"SimpleMechanism". Also we are not setting "auth" in connection string.


> Kerberos Authentication
> -----------------------
>
>                 Key: DRILL-4280
>                 URL: https://issues.apache.org/jira/browse/DRILL-4280
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Keys Botzum
>            Assignee: Sudheesh Katkam
>              Labels: security
>
> Drill should support Kerberos based authentication from clients. This means 
> that both the ODBC and JDBC drivers as well as the web/REST interfaces should 
> support inbound Kerberos. For Web this would most likely be SPNEGO while for 
> ODBC and JDBC this will be more generic Kerberos.
> Since Hive and much of Hadoop supports Kerberos there is a potential for a 
> lot of reuse of ideas if not implementation.
> Note that this is related to but not the same as 
> https://issues.apache.org/jira/browse/DRILL-3584 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to