[
https://issues.apache.org/jira/browse/DRILL-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014750#comment-16014750
]
ASF GitHub Bot commented on DRILL-5457:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/822#discussion_r117105800
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/AggPrelBase.java
---
@@ -51,7 +51,7 @@
public abstract class AggPrelBase extends DrillAggregateRelBase implements
Prel {
- protected static enum OperatorPhase {PHASE_1of1, PHASE_1of2, PHASE_2of2};
+ public static enum OperatorPhase {PHASE_1of1, PHASE_1of2, PHASE_2of2};
--- End diff --
Nit, but enum values are constants and so convention is all upper case:
maybe: PHASE1OF2 or PHASE1_OF_2 or PHASE_1_OF_2...
Not a big deal; the current form is a bit easier to read...
> Support Spill to Disk for the Hash Aggregate Operator
> -----------------------------------------------------
>
> Key: DRILL-5457
> URL: https://issues.apache.org/jira/browse/DRILL-5457
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Affects Versions: 1.10.0
> Reporter: Boaz Ben-Zvi
> Assignee: Boaz Ben-Zvi
> Fix For: 1.11.0
>
>
> Support gradual spilling memory to disk as the available memory gets too
> small to allow in memory work for the Hash Aggregate Operator.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
