[
https://issues.apache.org/jira/browse/DRILL-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014759#comment-16014759
]
ASF GitHub Bot commented on DRILL-5457:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/822#discussion_r117105244
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/ExternalSort.java
---
@@ -49,12 +49,19 @@ public int getOperatorType() {
return CoreOperatorType.EXTERNAL_SORT_VALUE;
}
- // Set here, rather than the base class, because this is the only
- // operator, at present, that makes use of the maximum allocation.
- // Remove this, in favor of the base class version, when Drill
- // sets the memory allocation for all operators.
-
+ /**
--- End diff --
Can just remove the Javadoc so it is inherited from the base method.
> Support Spill to Disk for the Hash Aggregate Operator
> -----------------------------------------------------
>
> Key: DRILL-5457
> URL: https://issues.apache.org/jira/browse/DRILL-5457
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Affects Versions: 1.10.0
> Reporter: Boaz Ben-Zvi
> Assignee: Boaz Ben-Zvi
> Fix For: 1.11.0
>
>
> Support gradual spilling memory to disk as the available memory gets too
> small to allow in memory work for the Hash Aggregate Operator.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)