[ 
https://issues.apache.org/jira/browse/DRILL-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027224#comment-16027224
 ] 

ASF GitHub Bot commented on DRILL-5457:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/822#discussion_r118811796
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
 ---
    @@ -166,20 +252,23 @@ public BatchHolder() {
         }
     
         private boolean updateAggrValues(int incomingRowIdx, int 
idxWithinBatch) {
    -      updateAggrValuesInternal(incomingRowIdx, idxWithinBatch);
    +      try { updateAggrValuesInternal(incomingRowIdx, idxWithinBatch); }
    +      catch (SchemaChangeException sc) { throw new 
DrillRuntimeException(sc); }
    --- End diff --
    
    Probably `IllegalStateException` to clearly state that this is a "this 
should never occur" kind of error.


> Support Spill to Disk for the Hash Aggregate Operator
> -----------------------------------------------------
>
>                 Key: DRILL-5457
>                 URL: https://issues.apache.org/jira/browse/DRILL-5457
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Execution - Relational Operators
>    Affects Versions: 1.10.0
>            Reporter: Boaz Ben-Zvi
>            Assignee: Boaz Ben-Zvi
>             Fix For: 1.11.0
>
>
> Support gradual spilling memory to disk as the available memory gets too 
> small to allow in memory work for the Hash Aggregate Operator.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to