[
https://issues.apache.org/jira/browse/DRILL-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027236#comment-16027236
]
ASF GitHub Bot commented on DRILL-5457:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/822#discussion_r118813700
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -306,14 +685,29 @@ public AggOutcome doWork() {
while (true) {
// Cleanup the previous batch since we are done processing it.
+ long pre = allocator.getAllocatedMemory();
for (VectorWrapper<?> v : incoming) {
v.getValueVector().clear();
}
+ long beforeAlloc = allocator.getAllocatedMemory();
+
--- End diff --
This function seems overly long: very hard to follow. Perhaps break out
each nested loop into a function. Since the functions are called once per
batch, the cost of a function call is lost in the noise of operating the
iterator hierarchy. The gain, however, is lower mental cost to understand
what's happening.
> Support Spill to Disk for the Hash Aggregate Operator
> -----------------------------------------------------
>
> Key: DRILL-5457
> URL: https://issues.apache.org/jira/browse/DRILL-5457
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Relational Operators
> Affects Versions: 1.10.0
> Reporter: Boaz Ben-Zvi
> Assignee: Boaz Ben-Zvi
> Fix For: 1.11.0
>
>
> Support gradual spilling memory to disk as the available memory gets too
> small to allow in memory work for the Hash Aggregate Operator.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
