[
https://issues.apache.org/jira/browse/DRILL-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050796#comment-16050796
]
ASF GitHub Bot commented on DRILL-5130:
---------------------------------------
GitHub user arina-ielchiieva opened a pull request:
https://github.com/apache/drill/pull/853
DRILL-5130: Fix explainTerms method for Values nodes to describe two
different Values nodes correctly
1. Factor out common logic for DrillValuesRel and ValuesPrel into
DrillValuesRelBase.
2. Revisit explainTerms to write full tuples content so consequently Values
nodes with the same row type and count but different values are considered to
be different.
3. Minor refactoring.
Details in Jira DRILL-5130.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arina-ielchiieva/drill DRILL-5130
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/853.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #853
----
commit 598a44f81cec5fdfc005573c39d790ff1b20eb6b
Author: Arina Ielchiieva <arina.yelchiy...@gmail.com>
Date: 2017-06-15T15:03:34Z
DRILL-5130: Fix explainTerms method for Values nodes to describe two
different Values nodes correctly
1. Factor out common logic for DrillValuesRel and ValuesPrel into
DrillValuesRelBase.
2. Revisit explainTerms to write full tuples content so consequently Values
nodes with the same row type and count but different values are considered to
be different.
3. Minor refactoring.
----
> UNION ALL difference in results
> -------------------------------
>
> Key: DRILL-5130
> URL: https://issues.apache.org/jira/browse/DRILL-5130
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Flow, Query Planning & Optimization
> Affects Versions: 1.9.0
> Reporter: Khurram Faraaz
> Assignee: Arina Ielchiieva
>
> Drill 1.9.0 git commit ID: 51246693
> {noformat}
> 0: jdbc:drill:schema=dfs.tmp> values(1,2,3,4,5,6) union all
> values(7,8,9,10,11,12);
> +---------+---------+---------+---------+---------+---------+
> | EXPR$0 | EXPR$1 | EXPR$2 | EXPR$3 | EXPR$4 | EXPR$5 |
> +---------+---------+---------+---------+---------+---------+
> | 7 | 8 | 9 | 10 | 11 | 12 |
> | 7 | 8 | 9 | 10 | 11 | 12 |
> +---------+---------+---------+---------+---------+---------+
> 2 rows selected (0.209 seconds)
> {noformat}
> Postgres 9.3
> {noformat}
> postgres=# values(1,2,3,4,5,6) union all values(7,8,9,10,11,12);
> column1 | column2 | column3 | column4 | column5 | column6
> ---------+---------+---------+---------+---------+---------
> 1 | 2 | 3 | 4 | 5 | 6
> 7 | 8 | 9 | 10 | 11 | 12
> (2 rows)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
