[
https://issues.apache.org/jira/browse/DRILL-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057869#comment-16057869
]
ASF GitHub Bot commented on DRILL-5130:
---------------------------------------
Github user jinfengni commented on a diff in the pull request:
https://github.com/apache/drill/pull/853#discussion_r123312311
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillValuesRelBase.java
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.planner.common;
+
+import org.apache.calcite.plan.RelOptCluster;
+import org.apache.calcite.plan.RelTraitSet;
+import org.apache.calcite.rel.AbstractRelNode;
+import org.apache.calcite.rel.RelWriter;
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.drill.common.JSONOptions;
+
+/**
+ * Base class for logical and physical Values implemented in Drill.
+ */
+public abstract class DrillValuesRelBase extends AbstractRelNode {
--- End diff --
Calcite has an abstract class Values. Neither of DrillValueRel or ValuePrel
extends from that Calcite class. Will it help solve the problem if we extend
from Calcite's class?
https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/rel/core/Values.java
> UNION ALL difference in results
> -------------------------------
>
> Key: DRILL-5130
> URL: https://issues.apache.org/jira/browse/DRILL-5130
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Flow, Query Planning & Optimization
> Affects Versions: 1.9.0
> Reporter: Khurram Faraaz
> Assignee: Arina Ielchiieva
> Fix For: 1.11.0
>
>
> Drill 1.9.0 git commit ID: 51246693
> {noformat}
> 0: jdbc:drill:schema=dfs.tmp> values(1,2,3,4,5,6) union all
> values(7,8,9,10,11,12);
> +---------+---------+---------+---------+---------+---------+
> | EXPR$0 | EXPR$1 | EXPR$2 | EXPR$3 | EXPR$4 | EXPR$5 |
> +---------+---------+---------+---------+---------+---------+
> | 7 | 8 | 9 | 10 | 11 | 12 |
> | 7 | 8 | 9 | 10 | 11 | 12 |
> +---------+---------+---------+---------+---------+---------+
> 2 rows selected (0.209 seconds)
> {noformat}
> Postgres 9.3
> {noformat}
> postgres=# values(1,2,3,4,5,6) union all values(7,8,9,10,11,12);
> column1 | column2 | column3 | column4 | column5 | column6
> ---------+---------+---------+---------+---------+---------
> 1 | 2 | 3 | 4 | 5 | 6
> 7 | 8 | 9 | 10 | 11 | 12
> (2 rows)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
