[
https://issues.apache.org/jira/browse/DRILL-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206559#comment-16206559
]
ASF GitHub Bot commented on DRILL-5876:
---------------------------------------
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/991#discussion_r144960078
--- Diff: exec/java-exec/pom.xml ---
@@ -701,18 +707,21 @@
<!--
Include the os-maven-plugin to get os.detected.classifier
-->
- <extension>
- <groupId>kr.motd.maven</groupId>
- <artifactId>os-maven-plugin</artifactId>
- <version>1.5.0.Final</version>
- </extension>
- </extensions>
+ <!-- Uncomment the following to get a debug build that allows
openssl support -->
--- End diff --
OK. So I tried to put the commented out code in a 'openssl' profile and
discovered that maven does not allow the <extensions> tag inside a profile.
Since the problem is essentially caused by this extension being included, not
being able to put it in the 'openssl' profile makes this useless.
There is a sort of a convoluted hack around this described here:
https://stackoverflow.com/questions/17639778/maven-3-profile-with-extensions.
IMO this introduces a bit of unreadable, magical stuff in the pom which I
would rather avoid.
What do you think?
> Remove netty-tcnative inclusion in java-exec/pom.xml
> ----------------------------------------------------
>
> Key: DRILL-5876
> URL: https://issues.apache.org/jira/browse/DRILL-5876
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Parth Chandra
>
> The inclusion of netty-tcnative is causing all kinds of problems. The os
> specific classifier required is determined by a maven extension which in
> turn requires an additional eclipse plugin. The eclipse plugin has a problem
> that may corrupt the current workspace.
> It is safe to not include the dependency since it is required only at
> runtime. The only case in which this is required is when a developer has to
> debug SSL/OpenSSL issues in the Java client or the server when launching from
> within an IDE. In this case, the dependency can be enabled by uncommenting
> the relevant lines in the pom file.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
