[ 
https://issues.apache.org/jira/browse/DRILL-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208629#comment-16208629
 ] 

ASF GitHub Bot commented on DRILL-5876:
---------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/991#discussion_r145289493
  
    --- Diff: exec/java-exec/pom.xml ---
    @@ -693,6 +699,19 @@
             </plugins>
           </build>
         </profile>
    +    <profile>
    +      <id>openssl</id>
    +      <dependencies>
    +        <dependency>
    +          <groupId>io.netty</groupId>
    +          <artifactId>netty-tcnative</artifactId>
    +          <version>2.0.1.Final</version>
    --- End diff --
    
    Please add provided scope.


> Remove netty-tcnative inclusion in java-exec/pom.xml
> ----------------------------------------------------
>
>                 Key: DRILL-5876
>                 URL: https://issues.apache.org/jira/browse/DRILL-5876
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Parth Chandra
>
> The inclusion of netty-tcnative is causing all kinds of problems. The os 
> specific classifier  required is determined by a maven extension which in 
> turn requires an additional eclipse plugin. The eclipse plugin has a problem 
> that may corrupt the current workspace.
> It is safe to not include the dependency since it is required only at 
> runtime. The only case in which this is required is when a developer has to 
> debug SSL/OpenSSL issues in the Java client or the server when launching from 
> within an IDE. In this case, the dependency can be enabled by uncommenting 
> the relevant lines in the pom file.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to