[
https://issues.apache.org/jira/browse/DRILL-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241558#comment-16241558
]
ASF GitHub Bot commented on DRILL-3640:
---------------------------------------
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149278905
--- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/StatementTest.java
---
@@ -61,55 +71,129 @@ public static void tearDownStatement() throws
SQLException {
//////////
// getQueryTimeout():
- /** Tests that getQueryTimeout() indicates no timeout set. */
+ /**
+ * Test for reading of default query timeout
+ */
@Test
- public void testGetQueryTimeoutSaysNoTimeout() throws SQLException {
- assertThat( statement.getQueryTimeout(), equalTo( 0 ) );
+ public void testDefaultGetQueryTimeout() throws SQLException {
+ Statement stmt = connection.createStatement();
+ int timeoutValue = stmt.getQueryTimeout();
+ assert( 0 == timeoutValue );
--- End diff --
I personally prefer the old construct using hamcrest. This `assert` is
actually less useful for two reasons:
- there's no error message (hamcrest prints a nice error message based on
the arguments)
- if the assert fails, you don't know `timeoutValue`'s value
> Drill JDBC driver support Statement.setQueryTimeout(int)
> --------------------------------------------------------
>
> Key: DRILL-3640
> URL: https://issues.apache.org/jira/browse/DRILL-3640
> Project: Apache Drill
> Issue Type: New Feature
> Components: Client - JDBC
> Affects Versions: 1.2.0
> Reporter: Chun Chang
> Assignee: Kunal Khatua
> Fix For: 1.12.0
>
>
> It would be nice if we have this implemented. Run away queries can be
> automatically canceled by setting the timeout.
> java.sql.SQLFeatureNotSupportedException: Setting network timeout is not
> supported.
> at
> org.apache.drill.jdbc.impl.DrillStatementImpl.setQueryTimeout(DrillStatementImpl.java:152)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
