[
https://issues.apache.org/jira/browse/DRILL-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242596#comment-16242596
]
ASF GitHub Bot commented on DRILL-3640:
---------------------------------------
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/1024#discussion_r149463638
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ---
@@ -239,6 +259,11 @@ QueryDataBatch getNext() throws UserException,
InterruptedException {
}
return qdb;
}
+
+ // Check and throw SQLTimeoutException
+ if ( parent.timeoutInSeconds > 0 &&
parent.elapsedTimer.elapsed(TimeUnit.SECONDS) >= parent.timeoutInSeconds ) {
--- End diff --
Good point, and I thought it might help in avoiding going into polling all
together.
However, the granularity of the timeout is in seconds, so 50ms is
insignificant. If I do a check before the poll, I'd need to do after the poll
as well.. over a 50ms window. So, a post-poll check works fine, because we'll,
at most, exceed the timeout by 50ms. So a timeout of 1sec would occur in
1.05sec. For any larger timeout values, the 50ms is of diminishing significance.
> Drill JDBC driver support Statement.setQueryTimeout(int)
> --------------------------------------------------------
>
> Key: DRILL-3640
> URL: https://issues.apache.org/jira/browse/DRILL-3640
> Project: Apache Drill
> Issue Type: New Feature
> Components: Client - JDBC
> Affects Versions: 1.2.0
> Reporter: Chun Chang
> Assignee: Kunal Khatua
> Fix For: 1.12.0
>
>
> It would be nice if we have this implemented. Run away queries can be
> automatically canceled by setting the timeout.
> java.sql.SQLFeatureNotSupportedException: Setting network timeout is not
> supported.
> at
> org.apache.drill.jdbc.impl.DrillStatementImpl.setQueryTimeout(DrillStatementImpl.java:152)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
