[
https://issues.apache.org/jira/browse/DRILL-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344399#comment-16344399
]
ASF GitHub Bot commented on DRILL-6032:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1101#discussion_r164623893
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
@@ -129,11 +143,16 @@ public ColumnSize(ValueVector v, String prefix) {
// No standard size for Union type
dataSize = v.getPayloadByteCount(valueCount);
break;
+ case GENERIC_OBJECT:
+ // We cannot provide a size for Generic Objects
--- End diff --
The `GENERIC_OBJECT` type is used any time we do a system table query:
system tables are represented as Java objects.
There is an open question about certain aggregate functions. (See a note
sent a week or so ago.) These aggregate functions use an `ObjectHolder` as
their `\@Workspace`. @Ben-Zvi and I discussed whether such aggregates are
spillable. This may be an unresolved issue.
> Use RecordBatchSizer to estimate size of columns in HashAgg
> -----------------------------------------------------------
>
> Key: DRILL-6032
> URL: https://issues.apache.org/jira/browse/DRILL-6032
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Major
> Fix For: 1.13.0
>
>
> We need to use the RecordBatchSize to estimate the size of columns in the
> Partition batches created by HashAgg.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
