[
https://issues.apache.org/jira/browse/DRILL-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347504#comment-16347504
]
ASF GitHub Bot commented on DRILL-6032:
---------------------------------------
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/1101#discussion_r165168294
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
---
@@ -84,13 +85,6 @@
public abstract class HashAggTemplate implements HashAggregator {
protected static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(HashAggregator.class);
- private static final int VARIABLE_MAX_WIDTH_VALUE_SIZE = 50;
- private static final int VARIABLE_MIN_WIDTH_VALUE_SIZE = 8;
-
- private static final boolean EXTRA_DEBUG_1 = false;
--- End diff --
Oh but there is! slf4j and logback have a feature called markers, which
allows you to associate a tag with a statement. When you print logs you can
specify to filter by level and by marker. There is a working example here
https://examples.javacodegeeks.com/enterprise-java/slf4j/slf4j-markers-example/
. I will update the log statements to use markers in this PR.
> Use RecordBatchSizer to estimate size of columns in HashAgg
> -----------------------------------------------------------
>
> Key: DRILL-6032
> URL: https://issues.apache.org/jira/browse/DRILL-6032
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Major
> Fix For: 1.13.0
>
>
> We need to use the RecordBatchSize to estimate the size of columns in the
> Partition batches created by HashAgg.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
