[ 
https://issues.apache.org/jira/browse/DRILL-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445823#comment-16445823
 ] 

ASF GitHub Bot commented on DRILL-6094:
---------------------------------------

GitHub user vvysotskyi opened a pull request:

    https://github.com/apache/drill/pull/1232

    DRILL-6094: Decimal data type enhancements

    For details please see [design 
document](https://docs.google.com/document/d/1kfWUZ_OsEmLOJu_tKZO0-ZUJwc52drrm15fyif7BmzQ/edit?usp=sharing)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vvysotskyi/drill DRILL-6094

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1232
    
----
commit a276870d6bad293da0311aed746fb68a2268700b
Author: Dave Oshinsky <daveoshinsky@...>
Date:   2016-02-09T22:37:47Z

    DRILL-4184: Support variable length decimal fields in parquet

commit 84a31b92dc86873d14a7be601d189bb1cbd59b7d
Author: Volodymyr Vysotskyi <vvovyk@...>
Date:   2018-04-05T12:35:42Z

    DRILL-6094: Decimal data type enhancements
    
    Add ExprVisitors for VARDECIMAL

commit e93cd93211ffa84586ee0d21dab26b128d81b290
Author: Volodymyr Vysotskyi <vvovyk@...>
Date:   2018-04-05T14:28:39Z

    DRILL-6094: Modify writers/readers to support VARDECIMAL
    
    - Added usage of VarDecimal for parquet, hive, maprdb, jdbc;
    - Added options to store decimals as int32 and int64 or 
fixed_len_byte_array or binary;

commit 8690897a4a2820f4e965cb562107782f1e57a99a
Author: Volodymyr Vysotskyi <vvovyk@...>
Date:   2018-04-03T13:27:25Z

    DRILL-6094: Refresh protobuf C++ source files

commit fbe93c46ed8a7e85a95da3ae145bfc00b7f17dd0
Author: Volodymyr Vysotskyi <vvovyk@...>
Date:   2018-04-05T14:44:05Z

    DRILL-6094: Add UDFs for VARDECIMAL data type
    
    - modify type inference rules
    - remove UDFs for obsolete DECIMAL types

commit 746e54f71464a9dea91c3860ba0346e40c1d6ddf
Author: Volodymyr Vysotskyi <vvovyk@...>
Date:   2018-04-05T14:48:31Z

    DRILL-6094: Enable DECIMAL data type by default

commit 46ce3d1504618ae7e547479280f5d60b35ec1caa
Author: Volodymyr Vysotskyi <vvovyk@...>
Date:   2018-04-05T14:51:39Z

    DRILL-6094: Add unit tests for DECIMAL data type

commit f62545390a37425b9fbb21881e4cd12ade337e73
Author: Volodymyr Vysotskyi <vvovyk@...>
Date:   2018-04-05T14:58:36Z

    DRILL-6094: Changes in C++ files

commit 7a04309605c0cd869a9eb55450aaa43c0088b425
Author: Volodymyr Vysotskyi <vvovyk@...>
Date:   2018-04-10T12:55:17Z

    DRILL-6094: Fix mapping for NLJ when literal with non-primitive type is 
used in join conditions

----


> Decimal data type enhancements
> ------------------------------
>
>                 Key: DRILL-6094
>                 URL: https://issues.apache.org/jira/browse/DRILL-6094
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.12.0
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>
> Currently, Decimal types are disabled by default since existing Decimal 
> implementation has a lot of flaws and performance problems. The goal of thisĀ 
> Jira to describe majority of them and possible ways of improving existing 
> implementation to be able to enable Decimal data types by default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to