[
https://issues.apache.org/jira/browse/DRILL-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450100#comment-16450100
]
ASF GitHub Bot commented on DRILL-6094:
---------------------------------------
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1232#discussion_r183777825
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestVarDecimalFunctions.java
---
@@ -0,0 +1,911 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.fn.impl;
+
+import org.apache.drill.categories.SqlFunctionTest;
+import org.apache.drill.exec.planner.physical.PlannerSettings;
+import org.apache.drill.test.BaseTestQuery;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import java.math.BigDecimal;
+import java.math.MathContext;
+import java.math.RoundingMode;
+
+@Category(SqlFunctionTest.class)
+public class TestVarDecimalFunctions extends BaseTestQuery {
+
+ // Tests for math functions
+
+ @Test
+ public void testDecimalAdd() throws Exception {
+ String query =
+ "select\n" +
+ // checks trimming of scale
+ "cast('999999999999999999999999999.92345678912' as DECIMAL(38,
11))\n" +
+ "+ cast('0.32345678912345678912345678912345678912' as
DECIMAL(38, 38)) as s1,\n" +
+ // sanitary checks
+ "cast('1234567891234567891234567891234567.89' as DECIMAL(36,
2))\n" +
+ "+ cast('123456789123456789123456789123456.789' as DECIMAL(36,
3)) as s2,\n" +
+ "cast('1234567891234567891234567891234567.89' as DECIMAL(36,
2))\n" +
+ "+ cast('0' as DECIMAL(36, 3)) as s3,\n" +
+ "cast('15.02' as DECIMAL(4, 2)) - cast('12.93' as DECIMAL(4,
2)) as s4,\n" +
+ "cast('11.02' as DECIMAL(4, 2)) - cast('12.93' as DECIMAL(4,
2)) as s5,\n" +
+ "cast('0' as DECIMAL(36, 2)) - cast('12.93' as DECIMAL(36, 2))
as s6,\n" +
+ // check trimming (negative scale)
+ "cast('99999999999999999999999999992345678912' as DECIMAL(38,
0))\n" +
+ "+ cast('32345678912345678912345678912345678912' as
DECIMAL(38, 0)) as s7";
+ try {
+ alterSession(PlannerSettings.ENABLE_DECIMAL_DATA_TYPE_KEY, true);
--- End diff --
Consider consider using `@BeforeClass` and `@AfterClass` for decimal option.
> Decimal data type enhancements
> ------------------------------
>
> Key: DRILL-6094
> URL: https://issues.apache.org/jira/browse/DRILL-6094
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.12.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.14.0
>
>
> Currently, Decimal types are disabled by default since existing Decimal
> implementation has a lot of flaws and performance problems. The goal of this
> Jira to describe majority of them and possible ways of improving existing
> implementation to be able to enable Decimal data types by default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
