[ 
https://issues.apache.org/jira/browse/DRILL-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450080#comment-16450080
 ] 

ASF GitHub Bot commented on DRILL-6094:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1232#discussion_r183756898
  
    --- Diff: 
exec/java-exec/src/main/codegen/templates/Decimal/CastDecimalFloat.java ---
    @@ -86,24 +46,21 @@ public void eval() {
      */
     
     @SuppressWarnings("unused")
    -@FunctionTemplate(name = "cast${type.to?upper_case}", scope = 
FunctionTemplate.FunctionScope.SIMPLE, nulls=NullHandling.NULL_IF_NULL)
    +@FunctionTemplate(name = "cast${type.to?upper_case}",
    +                  scope = FunctionTemplate.FunctionScope.SIMPLE,
    +                  nulls=NullHandling.NULL_IF_NULL)
    --- End diff --
    
    ` nulls=NullHandling.NULL_IF_NULL` ->  `nulls = NullHandling.NULL_IF_NULL`


> Decimal data type enhancements
> ------------------------------
>
>                 Key: DRILL-6094
>                 URL: https://issues.apache.org/jira/browse/DRILL-6094
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.12.0
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>              Labels: doc-impacting
>             Fix For: 1.14.0
>
>
> Currently, Decimal types are disabled by default since existing Decimal 
> implementation has a lot of flaws and performance problems. The goal of thisĀ 
> Jira to describe majority of them and possible ways of improving existing 
> implementation to be able to enable Decimal data types by default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to