[jira] [Commented] (DRILL-6094) Decimal data type enhancements

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DRILL-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452471#comment-16452471
 ] 

ASF GitHub Bot commented on DRILL-6094:
---------------------------------------

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1232#discussion_r184008988
  
    --- Diff: exec/vector/src/main/codegen/templates/NullReader.java ---
    @@ -31,19 +31,19 @@
      * This class is generated using freemarker and the ${.template_name} 
template.
      */
     @SuppressWarnings("unused")
    -public class NullReader extends AbstractBaseReader implements FieldReader{
    +public class NullReader extends AbstractBaseReader implements FieldReader {
       
       public static final NullReader INSTANCE = new NullReader();
       public static final NullReader EMPTY_LIST_INSTANCE = new 
NullReader(Types.repeated(TypeProtos.MinorType.NULL));
       public static final NullReader EMPTY_MAP_INSTANCE = new 
NullReader(Types.required(TypeProtos.MinorType.MAP));
       private MajorType type;
       
    -  private NullReader(){
    +  private NullReader() {
    --- End diff --
    
    Thanks, removed.


> Decimal data type enhancements
> ------------------------------
>
>                 Key: DRILL-6094
>                 URL: https://issues.apache.org/jira/browse/DRILL-6094
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.12.0
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>              Labels: doc-impacting
>             Fix For: 1.14.0
>
>
> Currently, Decimal types are disabled by default since existing Decimal 
> implementation has a lot of flaws and performance problems. The goal of this 
> Jira to describe majority of them and possible ways of improving existing 
> implementation to be able to enable Decimal data types by default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)