[jira] [Commented] (DRILL-6094) Decimal data type enhancements

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DRILL-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452469#comment-16452469
 ] 

ASF GitHub Bot commented on DRILL-6094:
---------------------------------------

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1232#discussion_r184008881
  
    --- Diff: 
exec/vector/src/main/codegen/templates/AbstractPromotableFieldWriter.java ---
    @@ -75,12 +75,19 @@ public void endList() {
     
       <#list vv.types as type><#list type.minor as minor><#assign name = 
minor.class?cap_first />
       <#assign fields = minor.fields!type.fields />
    -  <#if !minor.class?starts_with("Decimal") >
    +  <#if minor.class?contains("VarDecimal")>
    +  @Override
    +  public void write${minor.class}(BigDecimal value) {
    +    getWriter(MinorType.${name?upper_case}).write${minor.class}(value);
    +  }
    +  </#if>
    +
       @Override
       public void write(${name}Holder holder) {
         getWriter(MinorType.${name?upper_case}).write(holder);
       }
     
    +  <#if !minor.class?contains("Decimal") || 
minor.class?contains("VarDecimal")>
    --- End diff --
    
    Thanks, added.


> Decimal data type enhancements
> ------------------------------
>
>                 Key: DRILL-6094
>                 URL: https://issues.apache.org/jira/browse/DRILL-6094
>             Project: Apache Drill
>          Issue Type: Improvement
>    Affects Versions: 1.12.0
>            Reporter: Volodymyr Vysotskyi
>            Assignee: Volodymyr Vysotskyi
>            Priority: Major
>              Labels: doc-impacting
>             Fix For: 1.14.0
>
>
> Currently, Decimal types are disabled by default since existing Decimal 
> implementation has a lot of flaws and performance problems. The goal of this 
> Jira to describe majority of them and possible ways of improving existing 
> implementation to be able to enable Decimal data types by default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)