[
https://issues.apache.org/jira/browse/DRILL-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467758#comment-16467758
]
ASF GitHub Bot commented on DRILL-6348:
---------------------------------------
sachouche commented on a change in pull request #1237: DRILL-6348: Fixed code
so that Unordered Receiver reports its memory …
URL: https://github.com/apache/drill/pull/1237#discussion_r186814021
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/IncomingBuffers.java
##########
@@ -129,6 +134,10 @@ public int getRemainingRequired() {
return collectorMap.get(senderMajorFragmentId).getBuffers();
}
+ public void setOprAllocator(int senderMajorFragmentId, BufferAllocator
oprAllocator) {
Review comment:
I don't mind doing so if you think Collector is a top-level interface. I
wish there is a better way to indicate which class is an internal framework
class vs a public one safe for all operators to access. If you look closely at
the code, the DataCollector interface was created to allow multiple
implementations; the Drill code exposed the RawFragmentBatchProvider as the
main IF for operators to consume incoming data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unordered Receiver does not report its memory usage
> ---------------------------------------------------
>
> Key: DRILL-6348
> URL: https://issues.apache.org/jira/browse/DRILL-6348
> Project: Apache Drill
> Issue Type: Task
> Components: Execution - Flow
> Reporter: salim achouche
> Assignee: salim achouche
> Priority: Major
> Fix For: 1.14.0
>
>
> The Drill Profile functionality doesn't show any memory usage for the
> Unordered Receiver operator. This is problematic when analyzing OOM
> conditions since we cannot account for all of a query memory usage. This Jira
> is to fix memory reporting for the Unordered Receiver operator.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
