[ 
https://issues.apache.org/jira/browse/DRILL-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467817#comment-16467817
 ] 

ASF GitHub Bot commented on DRILL-6348:
---------------------------------------

vrozov commented on a change in pull request #1237: DRILL-6348: Fixed code so 
that Unordered Receiver reports its memory …
URL: https://github.com/apache/drill/pull/1237#discussion_r186829797
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/DataCollector.java
 ##########
 @@ -28,4 +29,16 @@
   public RawBatchBuffer[] getBuffers();
   public int getTotalIncomingFragments();
   public void close() throws Exception;
+  /**
+   * Allows an operator (e.g., receiver) to attach its buffer allocator to 
this Data Collector so that
+   * incoming batches are owned by the operator instead of the parent 
(fragment). Note
+   * that this operation is optional; the fragment allocator is used in case 
no operator invokes this method.
+   *
+   * @param oprAllocator operator buffer allocator
+   */
+  void setOprAllocator(BufferAllocator oprAllocator);
 
 Review comment:
   IMO, get/setAllocator is good enough.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Unordered Receiver does not report its memory usage
> ---------------------------------------------------
>
>                 Key: DRILL-6348
>                 URL: https://issues.apache.org/jira/browse/DRILL-6348
>             Project: Apache Drill
>          Issue Type: Task
>          Components: Execution - Flow
>            Reporter: salim achouche
>            Assignee: salim achouche
>            Priority: Major
>             Fix For: 1.14.0
>
>
> The Drill Profile functionality doesn't show any memory usage for the 
> Unordered Receiver operator. This is problematic when analyzing OOM 
> conditions since we cannot account for all of a query memory usage. This Jira 
> is to fix memory reporting for the Unordered Receiver operator.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to