[
https://issues.apache.org/jira/browse/DRILL-6353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16508490#comment-16508490
]
ASF GitHub Bot commented on DRILL-6353:
---------------------------------------
parthchandra commented on a change in pull request #1259: DRILL-6353: Upgrade
Parquet MR dependencies
URL: https://github.com/apache/drill/pull/1259#discussion_r194501388
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetMetadataCache.java
##########
@@ -737,6 +738,7 @@ public void testBooleanPartitionPruning() throws Exception
{
}
}
+ @Ignore
Review comment:
I also had an offline chat with Vlad on this one. The problem is that
Parquet has changed its behaviour and will not give us the stats for Decimal
when we read footers.
We have, therefore, no way of knowing whether Decimal stats are correct or
not (even if they are correct) unless we try to hack something in Parquet.
Hacking something in Parquet is not an option since that is exactly what this
PR is trying to fix !
Also, we have never supported Decimal in Drill, so we do not have to
consider backward compatibility. There are some users using Decimal (based on
posts to the mailing list), but the old implementation never worked reliably so
this will be an overall improvement for all parties.
+1. And thanks Vlad, Arina for pursuing this one to the end :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade Parquet MR dependencies
> -------------------------------
>
> Key: DRILL-6353
> URL: https://issues.apache.org/jira/browse/DRILL-6353
> Project: Apache Drill
> Issue Type: Task
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Major
> Fix For: 1.14.0
>
> Attachments: alltypes_optional.json, fixedlenDecimal.json
>
>
> Upgrade from a custom build {{1.8.1-drill-r0}} to Apache release {{1.10.0}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
