[
https://issues.apache.org/jira/browse/DRILL-6353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16510343#comment-16510343
]
ASF GitHub Bot commented on DRILL-6353:
---------------------------------------
vrozov commented on a change in pull request #1259: DRILL-6353: Upgrade Parquet
MR dependencies
URL: https://github.com/apache/drill/pull/1259#discussion_r194911872
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/PageReader.java
##########
@@ -445,25 +450,29 @@ public void clear(){
* @throws IOException An IO related condition
*/
void resetDefinitionLevelReader(int skipCount) throws IOException {
- if (parentColumnReader.columnDescriptor.getMaxDefinitionLevel() != 0) {
- throw new UnsupportedOperationException("Unsupoorted Operation");
- }
+
Preconditions.checkState(parentColumnReader.columnDescriptor.getMaxDefinitionLevel()
== 1);
Review comment:
In case `getMaxDefinitionLevel()` is zero, the
`resetDefinitionLevelReader()` should not be called as it unconditionally reads
`definitionLevels` that is only valid when `getMaxDefinitionLevel()` is not
zero.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade Parquet MR dependencies
> -------------------------------
>
> Key: DRILL-6353
> URL: https://issues.apache.org/jira/browse/DRILL-6353
> Project: Apache Drill
> Issue Type: Task
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Major
> Labels: ready-to-commit
> Fix For: 1.14.0
>
> Attachments: alltypes_optional.json, fixedlenDecimal.json
>
>
> Upgrade from a custom build {{1.8.1-drill-r0}} to Apache release {{1.10.0}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
