[
https://issues.apache.org/jira/browse/DRILL-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532943#comment-16532943
]
ASF GitHub Bot commented on DRILL-6422:
---------------------------------------
vrozov commented on a change in pull request #1264: DRILL-6422: Update guava
to 23.0 and shade it
URL: https://github.com/apache/drill/pull/1264#discussion_r200172239
##########
File path:
common/src/main/java/org/apache/drill/common/collections/MapWithOrdinal.java
##########
@@ -54,7 +53,7 @@
public class MapWithOrdinal<K, V> implements Map<K, V> {
private final static Logger logger =
LoggerFactory.getLogger(MapWithOrdinal.class);
- private final Map<K, Entry<Integer, V>> primary = Maps.newLinkedHashMap();
+ private final Map<K, Entry<Integer, V>> primary = new LinkedHashMap<>();
private final IntObjectHashMap<V> secondary = new IntObjectHashMap<>();
private final Map<K, V> delegate = new Map<K, V>() {
Review comment:
What is the purpose of the `delegate`? I'd recommend limiting this class
changes to updated imports only and refactor it in a separate JIRA/PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update guava to 23.0 and shade it
> ---------------------------------
>
> Key: DRILL-6422
> URL: https://issues.apache.org/jira/browse/DRILL-6422
> Project: Apache Drill
> Issue Type: Task
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Priority: Major
> Fix For: 1.15.0
>
>
> Some hadoop libraries use old versions of guava and most of them are
> incompatible with guava 23.0.
> To allow usage of new guava version, it should be shaded and shaded version
> should be used in the project.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
