[ https://issues.apache.org/jira/browse/DRILL-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532942#comment-16532942 ]
ASF GitHub Bot commented on DRILL-6422: --------------------------------------- vrozov commented on a change in pull request #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#discussion_r200171585 ########## File path: common/src/main/java/org/apache/drill/common/collections/MapWithOrdinal.java ########## @@ -129,22 +128,16 @@ public void clear() { @Override public Collection<V> values() { - return Lists.newArrayList(Iterables.transform(secondary.entries(), new Function<IntObjectMap.Entry<V>, V>() { - @Override - public V apply(IntObjectMap.Entry<V> entry) { - return Preconditions.checkNotNull(entry).value(); - } - })); + return Lists.newArrayList(Iterables.transform(secondary.entries(), + entry -> Preconditions.checkNotNull(entry).value())); } @Override public Set<Entry<K, V>> entrySet() { - return Sets.newHashSet(Iterables.transform(primary.entrySet(), new Function<Entry<K, Entry<Integer, V>>, Entry<K, V>>() { - @Override - public Entry<K, V> apply(Entry<K, Entry<Integer, V>> entry) { - return new AbstractMap.SimpleImmutableEntry<>(entry.getKey(), entry.getValue().getValue()); - } - })); + return primary.entrySet().stream() Review comment: What is the purpose of that code? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update guava to 23.0 and shade it > --------------------------------- > > Key: DRILL-6422 > URL: https://issues.apache.org/jira/browse/DRILL-6422 > Project: Apache Drill > Issue Type: Task > Reporter: Volodymyr Vysotskyi > Assignee: Volodymyr Vysotskyi > Priority: Major > Fix For: 1.15.0 > > > Some hadoop libraries use old versions of guava and most of them are > incompatible with guava 23.0. > To allow usage of new guava version, it should be shaded and shaded version > should be used in the project. -- This message was sent by Atlassian JIRA (v7.6.3#76005)