[
https://issues.apache.org/jira/browse/DRILL-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539599#comment-16539599
]
ASF GitHub Bot commented on DRILL-6579:
---------------------------------------
vrozov commented on a change in pull request #1361: DRILL-6579: Added sanity
checks to the Parquet reader to avoid infini…
URL: https://github.com/apache/drill/pull/1361#discussion_r201572784
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/BatchReader.java
##########
@@ -40,8 +40,11 @@ public int readBatch() throws Exception {
ColumnReader<?> firstColumnStatus = readState.getFirstColumnReader();
int currBatchNumRecords =
readState.batchSizerMgr().getCurrentRecordsPerBatch();
long recordsToRead = Math.min(currBatchNumRecords,
readState.getRemainingValuesToRead());
- int readCount = readRecords(firstColumnStatus, recordsToRead);
+ int readCount = 0;
Review comment:
use `?`: `int readCount = recordsToRead > 0 ? ...`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add sanity checks to Parquet Reader
> ------------------------------------
>
> Key: DRILL-6579
> URL: https://issues.apache.org/jira/browse/DRILL-6579
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: salim achouche
> Assignee: salim achouche
> Priority: Major
> Fix For: 1.14.0
>
>
> Add sanity checks to the Parquet reader to avoid infinite loops.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
