[
https://issues.apache.org/jira/browse/DRILL-6589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539915#comment-16539915
]
ASF GitHub Bot commented on DRILL-6589:
---------------------------------------
vdiravka commented on a change in pull request #1372: DRILL-6589: Push
transitive closure predicates past aggregates/projects
URL: https://github.com/apache/drill/pull/1372#discussion_r201650457
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/RuleInstance.java
##########
@@ -140,4 +145,14 @@
SubQueryRemoveRule SUB_QUERY_JOIN_REMOVE_RULE =
new
SubQueryRemoveRule.SubQueryJoinRemoveRule(DrillRelFactories.LOGICAL_BUILDER);
+
+ FilterAggregateTransposeRule DRILL_FILTER_AGGREGATE_TRANSPOSE_RULE =
Review comment:
Could you add this Instance in the `DrillFilterAggregateTransposeRule` as
`DRILL_INSTANCE`?
Do we want to match Filter and Aggregate with mixed `CONVENTION` `Trait`
(see `DrillFilterAggregateTransposeRule#matches()`)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Push transitive closure generated predicates past aggregates/projects
> ---------------------------------------------------------------------
>
> Key: DRILL-6589
> URL: https://issues.apache.org/jira/browse/DRILL-6589
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.13.0
> Reporter: Gautam Kumar Parai
> Assignee: Gautam Kumar Parai
> Priority: Major
> Fix For: 1.14.0
>
>
> Here is a sample query that may benefit from this optimization:
> SELECT * FROM T1 WHERE a1 = 5 AND a1 IN (SELECT a2 FROM T2);
> Here the transitive predicate a2 = 5 would be pushed past the aggregate due
> to this optimization.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
