[
https://issues.apache.org/jira/browse/DRILL-6589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554942#comment-16554942
]
ASF GitHub Bot commented on DRILL-6589:
---------------------------------------
gparai commented on a change in pull request #1372: DRILL-6589: Push transitive
closure predicates past aggregates/projects
URL: https://github.com/apache/drill/pull/1372#discussion_r204951494
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestAggregateFunctions.java
##########
@@ -732,6 +732,25 @@ public void testPushFilterInExprPastAgg() throws
Exception {
.build().run();
}
+ @Test
+ public void testTransitiveFilterPushPastAgg() throws Exception {
Review comment:
Moved testcase. I decided to remove the push filter past project rule from
TC. It was causing too many side-effects (plan patterns breaking etc.).
Moreover, it may not be very useful from a cost perspective. We can
re-introduce it if it were to be applied in a cost-based manner (via Volcano
planner).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Push transitive closure generated predicates past aggregates/projects
> ---------------------------------------------------------------------
>
> Key: DRILL-6589
> URL: https://issues.apache.org/jira/browse/DRILL-6589
> Project: Apache Drill
> Issue Type: Bug
> Affects Versions: 1.13.0
> Reporter: Gautam Kumar Parai
> Assignee: Gautam Kumar Parai
> Priority: Major
> Fix For: 1.15.0
>
>
> Here is a sample query that may benefit from this optimization:
> SELECT * FROM T1 WHERE a1 = 5 AND a1 IN (SELECT a2 FROM T2);
> Here the transitive predicate a2 = 5 would be pushed past the aggregate due
> to this optimization.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
