[
https://issues.apache.org/jira/browse/DRILL-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550937#comment-16550937
]
ASF GitHub Bot commented on DRILL-6373:
---------------------------------------
paul-rogers commented on issue #1244: DRILL-6373: Refactor Result Set Loader
for Union, List support
URL: https://github.com/apache/drill/pull/1244#issuecomment-406650835
@vrozov, perhaps a bit more explanation would help. The bug that you
described in the above comments was due (it seems) to a change I made in
nullable vector to make the `value` vector carry the correct metadata. This
caused problems when we "cloned" that vector. My first fix attempted to fix
that secondary issue (the cloning issue). After strong push-back from @sohami,
I decided we can't afford to fix the metadata inconsistency (at least not by
someone such as myself that is getting rusty on the code.)
So, instead, I backed out the metadata change, which should fix the vector
clone issue. Instead, in the result set loader code, I "parse" the vector type
and handle the metadata inconsistency.
As a result, the tests for this PR pass. I do need someone, however, to
rerun the pre-commit tests to determine if the clone issue has gone away; we
have no unit tests that test that particular case.
If we can run those tests, and they pass, then perhaps we can finally commit
this PR so I can add the final bit of code change in this series that we've
been trying to get in for six months now...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactor the Result Set Loader to prepare for Union, List support
> -----------------------------------------------------------------
>
> Key: DRILL-6373
> URL: https://issues.apache.org/jira/browse/DRILL-6373
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.13.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Attachments: 6373_Functional_Fail_07_13_1300.txt,
> drill-6373-with-6585-fix-functional-failure.txt
>
>
> As the next step in merging the "batch sizing" enhancements, refactor the
> {{ResultSetLoader}} and related classes to prepare for Union and List
> support. This fix follows the refactoring of the column accessors for the
> same purpose. Actual Union and List support is to follow in a separate PR.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
