[ https://issues.apache.org/jira/browse/DRILL-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16551293#comment-16551293 ]
ASF GitHub Bot commented on DRILL-6373: --------------------------------------- paul-rogers commented on issue #1244: DRILL-6373: Refactor Result Set Loader for Union, List support URL: https://github.com/apache/drill/pull/1244#issuecomment-406725968 @vrozov, if the bug was not introduced by this PR, then why have I been trying for months to fix it without access to the test environment? Why did the pre-commit tests pass before this PR, but fail with this PR? Just double-checked. This PR did not touch `AbstractMapVector` and so could not have introduced new issues in that vector. This PR did change the nullable vector. That change has been backed out and an alternative fix provided. Could the team Kindly fix the pre-existing bug so that the tests run clean before we attempt to retest this PR? Or, can the team re-run the pre-commit tests so that we know if the work around solves the issue, or if there is some deeper issue to fix? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Refactor the Result Set Loader to prepare for Union, List support > ----------------------------------------------------------------- > > Key: DRILL-6373 > URL: https://issues.apache.org/jira/browse/DRILL-6373 > Project: Apache Drill > Issue Type: Improvement > Affects Versions: 1.13.0 > Reporter: Paul Rogers > Assignee: Paul Rogers > Priority: Major > Attachments: 6373_Functional_Fail_07_13_1300.txt, > drill-6373-with-6585-fix-functional-failure.txt > > > As the next step in merging the "batch sizing" enhancements, refactor the > {{ResultSetLoader}} and related classes to prepare for Union and List > support. This fix follows the refactoring of the column accessors for the > same purpose. Actual Union and List support is to follow in a separate PR. -- This message was sent by Atlassian JIRA (v7.6.3#76005)