[
https://issues.apache.org/jira/browse/DRILL-6768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645084#comment-16645084
]
ASF GitHub Bot commented on DRILL-6768:
---------------------------------------
KazydubB commented on a change in pull request #1494: DRILL-6768: Improve
to_date, to_time and to_timestamp and correspondi…
URL: https://github.com/apache/drill/pull/1494#discussion_r224050959
##########
File path:
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/EmptyStringToDateTypeFunctions.java
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import org.apache.drill.exec.expr.annotations.Workspace;
+
+<@pp.dropOutputFile />
+
+<#list dateIntervalFunc.emptyStringToDateConversion as conversion>
+
+<@pp.changeOutputFile
name="/org/apache/drill/exec/expr/fn/impl/G${conversion.from}To${conversion.to}.java"
/>
+
+<#include "/@includes/license.ftl" />
+
+ package org.apache.drill.exec.expr.fn.impl;
+
+ import org.apache.drill.exec.expr.DrillSimpleFunc;
+ import org.apache.drill.exec.expr.annotations.FunctionTemplate;
+ import
org.apache.drill.exec.expr.annotations.FunctionTemplate.NullHandling;
+ import org.apache.drill.exec.expr.annotations.Output;
+ import org.apache.drill.exec.expr.annotations.Workspace;
+ import org.apache.drill.exec.expr.annotations.Param;
+ import org.apache.drill.exec.expr.holders.*;
+ import org.apache.drill.exec.record.RecordBatch;
+
+/*
+ * This class is generated using freemarker and the ${.template_name} template.
+ */
+@FunctionTemplate(name = "convert${conversion.from}To${conversion.to}", scope
= FunctionTemplate.FunctionScope.SIMPLE, nulls = NullHandling.INTERNAL)
+public class G${conversion.from}To${conversion.to} implements DrillSimpleFunc {
+
+ @Param ${conversion.from}Holder left;
+ @Param VarCharHolder right;
+ @Workspace org.joda.time.format.DateTimeFormatter format;
+ @Output ${conversion.to}Holder out;
+
+ public void setup() {
+ // Get the desired output format
+ byte[] buf = new byte[right.end - right.start];
+ right.buffer.getBytes(right.start, buf, 0, right.end - right.start);
+ String formatString = new String(buf,
com.google.common.base.Charsets.UTF_8);
+ format = org.joda.time.format.DateTimeFormat.forPattern(formatString);
+ }
+
+ public void eval() {
+ if (<#if conversion.from == "NullableVarChar">left.isSet == 0 ||
</#if>left.start == left.end) {
+ out.isSet = 0;
+ return;
+ }
+ out.isSet = 1;
+ // Get the input
+ byte[] buf1 = new byte[left.end - left.start];
+ left.buffer.getBytes(left.start, buf1, 0, left.end - left.start);
+ String input = new String(buf1, com.google.common.base.Charsets.UTF_8);
+
+ <#if conversion.to == "NullableDate">
+ out.value = (org.joda.time.DateMidnight.parse(input,
format).withZoneRetainFields(org.joda.time.DateTimeZone.UTC)).getMillis();
Review comment:
There are some differences in formatting (e.g. java.time uses 'HH' for hours
and joda.time accepts 'hh'). i removed this class but moved the generation
logic to ToDateTypeFunctions.java. I've left the values as is as it is better
to be done in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve to_date, to_time and to_timestamp and corresponding cast functions to
> handle empty string when `drill.exec.functions.cast_empty_string_to_null`
> option is enabled
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DRILL-6768
> URL: https://issues.apache.org/jira/browse/DRILL-6768
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.14.0
> Reporter: Bohdan Kazydub
> Assignee: Bohdan Kazydub
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.15.0
>
>
> When `drill.exec.functions.cast_empty_string_to_null` option is enabled
> `to_date`, `to_time` and `to_timestamp` functions while converting string to
> according type in case if null or empty string values are passed will return
> NULL (to avoid CASE clauses which are littering a query and will work in
> accordance with their respective CAST counterparts) for both cases.
>
>
>
> CASTs will be handled in a similar way (uniformly with numeric types):
>
> ||Value to cast||Now||Will be||
> |NULL|NULL|NULL|
> |'' (empty string)|Error in many cases (except numerical types)|NULL|
> CAST empty string to null (in case of enabled option) will be supported by
> DATE, TIME, TIMESTAMP, INTERVAL YEAR, INTERVAL MONTH and INTERVAL DAY
> functions in addition to numeric types.
>
> *For documentation*
> TBA
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
