[
https://issues.apache.org/jira/browse/DRILL-6768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645115#comment-16645115
]
ASF GitHub Bot commented on DRILL-6768:
---------------------------------------
KazydubB commented on a change in pull request #1494: DRILL-6768: Improve
to_date, to_time and to_timestamp and correspondi…
URL: https://github.com/apache/drill/pull/1494#discussion_r223624064
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java
##########
@@ -456,8 +456,8 @@ private ExecConstants() {
public static final PositiveLongValidator SLICE_TARGET_OPTION = new
PositiveLongValidator(SLICE_TARGET, Long.MAX_VALUE,
new OptionDescription("The number of records manipulated within a
fragment before Drill parallelizes operations."));
- public static final String CAST_TO_NULLABLE_NUMERIC =
"drill.exec.functions.cast_empty_string_to_null";
- public static final BooleanValidator CAST_TO_NULLABLE_NUMERIC_OPTION = new
BooleanValidator(CAST_TO_NULLABLE_NUMERIC,
+ public static final String CAST_EMPTY_STRING_TO_NULL =
"drill.exec.functions.cast_empty_string_to_null";
Review comment:
This option was designed to treat empty string as null when casting empty
string to numeric types. As its use was extended (to date and interval types)
it got renamed to reflect a more general purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve to_date, to_time and to_timestamp and corresponding cast functions to
> handle empty string when `drill.exec.functions.cast_empty_string_to_null`
> option is enabled
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: DRILL-6768
> URL: https://issues.apache.org/jira/browse/DRILL-6768
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.14.0
> Reporter: Bohdan Kazydub
> Assignee: Bohdan Kazydub
> Priority: Major
> Labels: doc-impacting
> Fix For: 1.15.0
>
>
> When `drill.exec.functions.cast_empty_string_to_null` option is enabled
> `to_date`, `to_time` and `to_timestamp` functions while converting string to
> according type in case if null or empty string values are passed will return
> NULL (to avoid CASE clauses which are littering a query and will work in
> accordance with their respective CAST counterparts) for both cases.
>
>
>
> CASTs will be handled in a similar way (uniformly with numeric types):
>
> ||Value to cast||Now||Will be||
> |NULL|NULL|NULL|
> |'' (empty string)|Error in many cases (except numerical types)|NULL|
> CAST empty string to null (in case of enabled option) will be supported by
> DATE, TIME, TIMESTAMP, INTERVAL YEAR, INTERVAL MONTH and INTERVAL DAY
> functions in addition to numeric types.
>
> *For documentation*
> TBA
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
