[
https://issues.apache.org/jira/browse/DRILL-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814495#comment-16814495
]
ASF GitHub Bot commented on DRILL-7160:
---------------------------------------
kkhatua commented on pull request #1742: DRILL-7160: e.q.max_rows QUERY-level
option shown even if not set
URL: https://github.com/apache/drill/pull/1742#discussion_r273990569
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
##########
@@ -336,7 +336,8 @@ public String getOperatorsJSON() {
}
public Map<String, String> getQueryOptions() {
- return getOptions(o -> OptionValue.OptionScope.QUERY == o.getScope());
+ // Skip reporting QUERY_MAX_ROWS if it is inapplicable and set to zero
(e.g. query -> SHOW FILES)
+ return getOptions(o -> OptionValue.OptionScope.QUERY == o.getScope() &&
!(ExecConstants.QUERY_MAX_ROWS.equals(o.getName()) &&
String.valueOf(o.getValue()).equals("0")));
Review comment:
Agreed. I am not sure, but I think I did this here
https://github.com/apache/drill/blob/c3ee7949656fb4c1b144e1633f97002c159ec8f3/exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java#L120
because of the complexity in the logic and (I think) because without this,
the session value (0) gets precedence when the SYSTEM default exists.
I can revisit this post release to avoid blocking the release for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> exec.query.max_rows QUERY-level options are shown on Profiles tab
> -----------------------------------------------------------------
>
> Key: DRILL-7160
> URL: https://issues.apache.org/jira/browse/DRILL-7160
> Project: Apache Drill
> Issue Type: Bug
> Components: Web Server
> Affects Versions: 1.16.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Kunal Khatua
> Priority: Blocker
> Fix For: 1.16.0
>
>
> As [~arina] has noticed, option {{exec.query.max_rows}} is shown on Web UI's
> Profiles even when it was not set explicitly. The issue is because the option
> is being set on the query level internally.
> From the code, looks like it is set in
> {{DrillSqlWorker.checkAndApplyAutoLimit()}}, and perhaps a check whether the
> value differs from the existing one should be added.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
