[
https://issues.apache.org/jira/browse/DRILL-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814742#comment-16814742
]
ASF GitHub Bot commented on DRILL-7160:
---------------------------------------
kkhatua commented on issue #1742: DRILL-7160: e.q.max_rows QUERY-level option
shown even if not set
URL: https://github.com/apache/drill/pull/1742#issuecomment-481803435
@vvysotskyi , @arina-ielchiieva
With the latest update, for non-applicable queries, there are no options
shown that indicate that the `max_rows` has been set.
For applicable queries, based on the combination of what the SESSION and
SYSTEM (default) values are, you get the following outcome with the scope of
the option also indicated as shown in the profile:
| SYSTEM | SESSION | Final | ScopeSet |
|----------------|--------------|-------------|----------------|
| 0 | 0 | 0 |
N/A |
| 15 | 0 | 15 |
N/A |
| 0 | 10 | 10 |
SESSION |
| 15 | 10 | 10 |
SESSION |
| 15 | 20 | 15 |
QUERY |
The last one is required because there is no way for me to remove the
SESSION level value and let only the SYSTEM value persist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> exec.query.max_rows QUERY-level options are shown on Profiles tab
> -----------------------------------------------------------------
>
> Key: DRILL-7160
> URL: https://issues.apache.org/jira/browse/DRILL-7160
> Project: Apache Drill
> Issue Type: Bug
> Components: Web Server
> Affects Versions: 1.16.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Kunal Khatua
> Priority: Blocker
> Fix For: 1.16.0
>
>
> As [~arina] has noticed, option {{exec.query.max_rows}} is shown on Web UI's
> Profiles even when it was not set explicitly. The issue is because the option
> is being set on the query level internally.
> From the code, looks like it is set in
> {{DrillSqlWorker.checkAndApplyAutoLimit()}}, and perhaps a check whether the
> value differs from the existing one should be added.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
