[
https://issues.apache.org/jira/browse/DRILL-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014623#comment-17014623
]
ASF GitHub Bot commented on DRILL-7506:
---------------------------------------
KazydubB commented on pull request #1948: DRILL-7506: Simplify code gen error
handling
URL: https://github.com/apache/drill/pull/1948#discussion_r366000321
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/LateralJoinBatch.java
##########
@@ -531,13 +523,10 @@ private IterOutcome processRightBatch() {
// Right batch with OK_NEW_SCHEMA can be non-empty so update the
rightJoinIndex correctly and pass the
// new schema downstream with empty batch and later with subsequent
next() call the join output will be
// produced
- if (handleSchemaChange()) {
- container.setRecordCount(0);
- rightJoinIndex = (right.getRecordCount() > 0) ? 0 : -1;
- return OK_NEW_SCHEMA;
- } else {
- return STOP;
- }
+ handleSchemaChange();
+ container.setRecordCount(0);
Review comment:
Does `container#setEmpty()` work here, or `setRecordCount(0)` should be used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Simplify code gen error handling
> --------------------------------
>
> Key: DRILL-7506
> URL: https://issues.apache.org/jira/browse/DRILL-7506
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> Code generation can generate a variety of errors. Most operators bubble these
> exceptions up several layers in the code before catching them. This patch
> moves error handling closer to the code gen itself to allow a) simpler code,
> and b) clearer error messages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
