[
https://issues.apache.org/jira/browse/DRILL-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014621#comment-17014621
]
ASF GitHub Bot commented on DRILL-7506:
---------------------------------------
KazydubB commented on pull request #1948: DRILL-7506: Simplify code gen error
handling
URL: https://github.com/apache/drill/pull/1948#discussion_r366001563
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalOperatorUtil.java
##########
@@ -46,10 +46,13 @@ private PhysicalOperatorUtil() {}
}
/**
- * Helper method to create a list of MinorFragmentEndpoint instances from a
given endpoint assignment list.
+ * Helper method to create a list of MinorFragmentEndpoint instances from a
+ * given endpoint assignment list.
*
- * @param endpoints Assigned endpoint list. Index of each endpoint in list
indicates the MinorFragmentId of the
- * fragment that is assigned to the endpoint.
+ * @param endpoints
Review comment:
nit: no need to start from a new line.
Can you add Java docs to `@return`, please? :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Simplify code gen error handling
> --------------------------------
>
> Key: DRILL-7506
> URL: https://issues.apache.org/jira/browse/DRILL-7506
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.17.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.18.0
>
>
> Code generation can generate a variety of errors. Most operators bubble these
> exceptions up several layers in the code before catching them. This patch
> moves error handling closer to the code gen itself to allow a) simpler code,
> and b) clearer error messages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
