[
https://issues.apache.org/jira/browse/DRILL-7842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268166#comment-17268166
]
ASF GitHub Bot commented on DRILL-7842:
---------------------------------------
eevanwong opened a new pull request #2146:
URL: https://github.com/apache/drill/pull/2146
#
[DRILL-7842](https://issues.apache.org/jira/projects/DRILL/issues/DRILL-7842)
## Description
Fixed BaseTestInheritance (now called TestforBaseTestInheritance) so that it
runs during maven test. Also fixed tests that were not inherited from the
BaseTest class:
```
org.apache.drill.exec.physical.impl.scan.v3.schema.TestProjectedPath,
org.apache.drill.exec.physical.impl.TestStackAnalyzer,
org.apache.drill.exec.physical.resultSet.impl.TestProjectionFilter,
org.apache.drill.exec.physical.resultSet.project.TestProjectedPath,
org.apache.drill.exec.physical.impl.scan.v3.schema.TestDynamicSchemaFilter,
org.apache.drill.exec.physical.impl.scan.v3.schema.TestSchemaTrackerDefined
```
## Documentation
(Please describe user-visible changes similar to what should appear in the
Drill documentation.)
I'm fairly certain this is N/A for this issue as it is quite small?
## Testing
Ran maven test. Confirmed that it runs and no errors.
```
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
105.013 s - in org.apache.drill.TestforBaseTestInheritance
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix BaseTestInheritance test case
> ---------------------------------
>
> Key: DRILL-7842
> URL: https://issues.apache.org/jira/browse/DRILL-7842
> Project: Apache Drill
> Issue Type: Test
> Components: Tools, Build & Test
> Affects Versions: 1.18.0
> Reporter: Vitalii Diravka
> Priority: Trivial
> Fix For: Future
>
>
> *[Very minor, but can be good for newcomers]*
> BaseTestInheritance test is not running in maven test phase. It is due to
> naming. The only tests starting from _Test*_ are running.
> Need to rename it to _TestInheritanceFromBaseClass_ (for example) and fix
> tests, which are currently isn't inherited from the _BaseTest_ class:
> {code:java}
> [org.apache.drill.exec.physical.impl.scan.v3.schema.TestProjectedPath,
> org.apache.drill.exec.physical.impl.TestStackAnalyzer,
> org.apache.drill.exec.physical.resultSet.impl.TestProjectionFilter,
> org.apache.drill.exec.physical.resultSet.project.TestProjectedPath,
> org.apache.drill.exec.physical.impl.scan.v3.schema.TestDynamicSchemaFilter,
> org.apache.drill.exec.physical.impl.scan.v3.schema.TestSchemaTrackerDefined]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
