[
https://issues.apache.org/jira/browse/DRILL-7842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268173#comment-17268173
]
ASF GitHub Bot commented on DRILL-7842:
---------------------------------------
cgivre commented on pull request #2146:
URL: https://github.com/apache/drill/pull/2146#issuecomment-763076084
@eevanwong
Thanks for the contribution and welcome to Drill. Assuming this passes CI,
I'll merge tomorrow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix BaseTestInheritance test case
> ---------------------------------
>
> Key: DRILL-7842
> URL: https://issues.apache.org/jira/browse/DRILL-7842
> Project: Apache Drill
> Issue Type: Test
> Components: Tools, Build & Test
> Affects Versions: 1.18.0
> Reporter: Vitalii Diravka
> Priority: Trivial
> Fix For: Future
>
>
> *[Very minor, but can be good for newcomers]*
> BaseTestInheritance test is not running in maven test phase. It is due to
> naming. The only tests starting from _Test*_ are running.
> Need to rename it to _TestInheritanceFromBaseClass_ (for example) and fix
> tests, which are currently isn't inherited from the _BaseTest_ class:
> {code:java}
> [org.apache.drill.exec.physical.impl.scan.v3.schema.TestProjectedPath,
> org.apache.drill.exec.physical.impl.TestStackAnalyzer,
> org.apache.drill.exec.physical.resultSet.impl.TestProjectionFilter,
> org.apache.drill.exec.physical.resultSet.project.TestProjectedPath,
> org.apache.drill.exec.physical.impl.scan.v3.schema.TestDynamicSchemaFilter,
> org.apache.drill.exec.physical.impl.scan.v3.schema.TestSchemaTrackerDefined]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
