[
https://issues.apache.org/jira/browse/DRILL-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312888#comment-17312888
]
ASF GitHub Bot commented on DRILL-7828:
---------------------------------------
paul-rogers commented on a change in pull request #2192:
URL: https://github.com/apache/drill/pull/2192#discussion_r605398703
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/columns/ColumnsScanFramework.java
##########
@@ -103,7 +103,7 @@ protected void configure() {
}
@Override
- protected SchemaNegotiatorImpl newNegotiator() {
+ public SchemaNegotiatorImpl newNegotiator() {
Review comment:
As it turns out, cleaning up this kind of issue is one of the things
that the new version does.
There is also a race condition. The schema negotiator is passed into the
reader; it is not meant to be obtained elsewhere. In general, the framework
does a bunch of initialization, getting things ready. Then, each reader is
created, one at a time, passing in the schema negotiator. If we have code
trying to access it at some other time, then we'd have to review all that code
to see if new pattern works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor Pcap and Pcapng format plugin
> --------------------------------------
>
> Key: DRILL-7828
> URL: https://issues.apache.org/jira/browse/DRILL-7828
> Project: Apache Drill
> Issue Type: Sub-task
> Reporter: Cong Luo
> Assignee: Vitalii Diravka
> Priority: Major
> Fix For: 1.19.0
>
>
> We can check the file's magic number, If that magic number indicates PCAP
> then use the existing reader, If the magic number indicates PCAPNG, use the
> refactored NG reader.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
