[
https://issues.apache.org/jira/browse/DRILL-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329463#comment-17329463
]
ASF GitHub Bot commented on DRILL-7828:
---------------------------------------
vdiravka commented on a change in pull request #2192:
URL: https://github.com/apache/drill/pull/2192#discussion_r603043283
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/columns/ColumnsScanFramework.java
##########
@@ -103,7 +103,7 @@ protected void configure() {
}
@Override
- protected SchemaNegotiatorImpl newNegotiator() {
+ public SchemaNegotiatorImpl newNegotiator() {
Review comment:
I agree the negotiator is an internal staff of `fileFramework`, so not
good to make it public.
Changed it with adding `fileSystem()` method in `FileScanFramework`. For me
it looks essential here.
I think there is no need here to create something more powerful for just
obtaining `DrillFileSystem` object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Refactor Pcap and Pcapng format plugin
> --------------------------------------
>
> Key: DRILL-7828
> URL: https://issues.apache.org/jira/browse/DRILL-7828
> Project: Apache Drill
> Issue Type: Sub-task
> Reporter: Cong Luo
> Assignee: Vitalii Diravka
> Priority: Major
> Fix For: 1.19.0
>
>
> We can check the file's magic number, If that magic number indicates PCAP
> then use the existing reader, If the magic number indicates PCAPNG, use the
> refactored NG reader.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
