[ 
https://issues.apache.org/jira/browse/DRILL-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329905#comment-17329905
 ] 

ASF GitHub Bot commented on DRILL-7828:
---------------------------------------

vdiravka commented on pull request #2192:
URL: https://github.com/apache/drill/pull/2192#issuecomment-825296554


   As I told earlier we don't break backward compatibility: in second commit 
`Changes related to CR` I have added support for old plugins and in third 
commit `Changes related to CR2` I have added test case to check it. So we are 
fine to use the new config and don't fail, if old plugin config is places in PS
   @paul-rogers Could you pls check again?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Refactor Pcap and Pcapng format plugin
> --------------------------------------
>
>                 Key: DRILL-7828
>                 URL: https://issues.apache.org/jira/browse/DRILL-7828
>             Project: Apache Drill
>          Issue Type: Sub-task
>            Reporter: Cong Luo
>            Assignee: Vitalii Diravka
>            Priority: Major
>             Fix For: 1.19.0
>
>
> We can check the file's magic number, If that magic number indicates PCAP 
> then use the existing reader, If the magic number indicates PCAPNG, use the 
> refactored NG reader.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to