[
https://issues.apache.org/jira/browse/DRILL-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17386500#comment-17386500
]
ASF GitHub Bot commented on DRILL-7926:
---------------------------------------
paul-rogers commented on pull request #2268:
URL: https://github.com/apache/drill/pull/2268#issuecomment-885869395
@dzamo, thanks much for inspecting the code and for the tests.
@oleg-zinovev, the reason you are dealing with this mess is that Drill clearly
did not have adequate tests in this area. Please, as part of your work, go
ahead and add sufficient unit tests to check for the cases which @dzamo showed
and for the other cases in my comments.
You may find that things don't work because of bugs in other areas. You
seemed to find places where Drill deals with TIMESTAMP in UTC. As explained
above, those are bugs: the bulk of Drill is written (alas) to assume TIMESTAMP
is local time.
If it were me, I would implement the age function as a normal Java function,
test the heck out of it, then wrap it in a UDF. However, if you prefer, you can
implement the logic in the UDF, then test the cases by running queries, which
requires that you have a working reader and working conversion from Drill's
output to some date/time class. Since I suspect these may also be buggy, doing
"full up" testing may be a bit frustrating. Still, your choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> The " age " function is not working properly.
> ---------------------------------------------
>
> Key: DRILL-7926
> URL: https://issues.apache.org/jira/browse/DRILL-7926
> Project: Apache Drill
> Issue Type: Bug
> Components: Functions - Drill
> Affects Versions: 1.17.0, 1.18.0
> Reporter: Александр Глухов
> Priority: Blocker
> Attachments: image-2021-05-13-16-17-21-154.png, screenshot-1.png,
> screenshot-2.png
>
>
> The " age " function is not working properly.
> *Playback steps*
> {code:sql}
> select extract(year from m. "years") `years` from (select age('2021-05-13',
> '2007-07-02') `years") m{code}
> *Expected result* 13.
> *Actual result* 14.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
