[
https://issues.apache.org/jira/browse/DRILL-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397400#comment-17397400
]
ASF GitHub Bot commented on DRILL-7984:
---------------------------------------
Leon-WTF commented on a change in pull request #2290:
URL: https://github.com/apache/drill/pull/2290#discussion_r686905466
##########
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/clickhouse/ClickhouseDialect.java
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.jdbc.clickhouse;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.sql.SqlBasicTypeNameSpec;
+import org.apache.calcite.sql.SqlDataTypeSpec;
+import org.apache.calcite.sql.SqlDialect;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.SqlUserDefinedTypeNameSpec;
+import org.apache.calcite.sql.SqlWriter;
+import org.apache.calcite.sql.parser.SqlParserPos;
+import org.apache.calcite.sql.type.BasicSqlType;
+
+/**
+ * @author feiteng.wtf
+ * @date 2021-08-08
+ */
+public class ClickhouseDialect extends SqlDialect {
Review comment:
Thanks, but as it is not included in the current version of calcite, so
I will need to do a cherry pick on DrillCalcite1.21.0 of
https://github.com/vvysotskyi/drill-calcite.git and update to 1.21.0-drill-r4,
right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Support Clickhouse using JDBC Storage Plugin
> --------------------------------------------
>
> Key: DRILL-7984
> URL: https://issues.apache.org/jira/browse/DRILL-7984
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - JDBC
> Reporter: wtf
> Assignee: wtf
> Priority: Major
>
> Trino(Formerly PrestoSQL, branched from Presto) has already supportted
> [Clickhouse|[https://trino.io/docs/current/connector/clickhouse.html]|https://trino.io/docs/current/connector/clickhouse.html],]
> using
> [clickhouse-jdbc|[https://github.com/ClickHouse/clickhouse-jdbc]|https://github.com/ClickHouse/clickhouse-jdbc]
> When connecting to clickhouse using drill jdbc plugin, found one uncompatible
> place:
> clickhouse-jdbc return constant string "default" when call getCatalogs, and
> return all databases when call getSchemas(input catalog is not used). All
> schemas will be appended after the "default" catalog, which will cause the
> query to fail.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
